superreview cancelled: [Bug 340273] Can't drag proxy icons from tabs to location bar if focus is outside location bar : [Attachment 239703] This patch is the same as above, with an addition to fix a c

Samuel Sidler (:sps) <samuel.sidler@gmail.com> has cancelled Stuart Morgan
<stuart.morgan@alumni.case.edu>'s request for superreview:
Bug 340273: Can't drag proxy icons from tabs to location bar if focus is
outside location bar
https://bugzilla.mozilla.org/show_bug.cgi?id=340273

Attachment 239703: This patch is the same as above, with an addition to fix a
compiler warning not related to this bug
https://bugzilla.mozilla.org/attachment.cgi?id=239703&action=edit
0
bugzilla
9/24/2006 4:59:15 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
487 Views

Similar Articles

[PageSpeed] 57

Reply:

Similar Artilces:

superreview requested: [Bug 340273] Can't drag proxy icons from tabs to location bar if focus is outside location bar : [Attachment 239703] This patch is the same as above, with an addition to fix a c
Stuart Morgan <stuart.morgan@alumni.case.edu> has asked Simon Fraser <sfraser_bugs@smfr.org> for superreview: Bug 340273: Can't drag proxy icons from tabs to location bar if focus is outside location bar https://bugzilla.mozilla.org/show_bug.cgi?id=340273 Attachment 239703: This patch is the same as above, with an addition to fix a compiler warning not related to this bug https://bugzilla.mozilla.org/attachment.cgi?id=239703&action=edit ------- Additional Comments from Stuart Morgan <stuart.morgan@alumni.case.edu> Looks good, r=me. Thanks! As an added b...

superreview granted: [Bug 340273] Can't drag proxy icons from tabs to location bar if focus is outside location bar : [Attachment 239867] Same patch, just moved around the #import.
Simon Fraser <sfraser_bugs@smfr.org> has granted Samuel Sidler (:sps) <samuel.sidler@gmail.com>'s request for superreview: Bug 340273: Can't drag proxy icons from tabs to location bar if focus is outside location bar https://bugzilla.mozilla.org/show_bug.cgi?id=340273 Attachment 239867: Same patch, just moved around the #import. https://bugzilla.mozilla.org/attachment.cgi?id=239867&action=edit ------- Additional Comments from Simon Fraser <sfraser_bugs@smfr.org> Looks good but please remove the spaces from inside the () in performDragOperation. ...

superreview requested: [Bug 340273] Can't drag proxy icons from tabs to location bar if focus is outside location bar : [Attachment 239867] Same patch, just moved around the #import.
Samuel Sidler (:sps) <samuel.sidler@gmail.com> has asked Simon Fraser <sfraser_bugs@smfr.org> for superreview: Bug 340273: Can't drag proxy icons from tabs to location bar if focus is outside location bar https://bugzilla.mozilla.org/show_bug.cgi?id=340273 Attachment 239867: Same patch, just moved around the #import. https://bugzilla.mozilla.org/attachment.cgi?id=239867&action=edit ------- Additional Comments from Samuel Sidler (:sps) <samuel.sidler@gmail.com> Carrying over review... (Typically if there's just a small change to make, you can carry o...

superreview canceled: [Bug 406894] Icons in the location bar and search bar need hover and depressed states (web feed)(star)(location bar)(bookmarks) : [Attachment 318028] patch
Kai Liu <kliu.bugzilla.3c9f@mail.kailiu.com> has canceled Kai Liu <kliu.bugzilla.3c9f@mail.kailiu.com>'s request for superreview: Bug 406894: Icons in the location bar and search bar need hover and depressed states (web feed)(star)(location bar)(bookmarks) https://bugzilla.mozilla.org/show_bug.cgi?id=406894 Attachment 318028: patch https://bugzilla.mozilla.org/attachment.cgi?id=318028&action=edit ...

superreview cancelled: [Bug 78786] [FIX] Can't scroll URL bar history drop down with mouse wheel : [Attachment 153557] Patch A rev. 1 (must have patch from bug 97283 first)
Mats Palmgren <mats.palmgren@bredband.net> has cancelled Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 78786: [FIX] Can't scroll URL bar history drop down with mouse wheel http://bugzilla.mozilla.org/show_bug.cgi?id=78786 Attachment 153557: Patch A rev. 1 (must have patch from bug 97283 first) http://bugzilla.mozilla.org/attachment.cgi?id=153557&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> "Patch B rev. 2" on bug 97283 now includes a fix for this bug too. ...

superreview requested: [Bug 406894] Icons in the location bar and search bar need hover and depressed states (web feed)(star)(location bar)(bookmarks) : [Attachment 318028] patch
Kai Liu <kliu.bugzilla.3c9f@mail.kailiu.com> has asked Mike Beltzner <beltzner@mozilla.com> for superreview: Bug 406894: Icons in the location bar and search bar need hover and depressed states (web feed)(star)(location bar)(bookmarks) https://bugzilla.mozilla.org/show_bug.cgi?id=406894 Attachment 318028: patch https://bugzilla.mozilla.org/attachment.cgi?id=318028&action=edit ------- Additional Comments from Kai Liu <kliu.bugzilla.3c9f@mail.kailiu.com> Since nobody is taking this bug... In addition to adding hover states, this patch also addresses the issue...

superreview requested: [Bug 304388] Add hostname to title bar of windows that don't have location bars : [Attachment 192787] update dveditz's patch to trunk
Jesse Ruderman <jruderman@gmail.com> has asked Boris Zbarsky (gone till Aug 14) <bzbarsky@mit.edu> for superreview: Bug 304388: Add hostname to title bar of windows that don't have location bars https://bugzilla.mozilla.org/show_bug.cgi?id=304388 Attachment 192787: update dveditz's patch to trunk https://bugzilla.mozilla.org/attachment.cgi?id=192787&action=edit ------- Additional Comments from Jesse Ruderman <jruderman@gmail.com> I hand-applied dveditz's patch (https://bugzilla.mozilla.org/show_bug.cgi?id=22183#c238) to the trunk and edited a few ...

superreview denied: [Bug 304388] Add hostname to title bar of windows that don't have location bars : [Attachment 192787] update dveditz's patch to trunk
Boris Zbarsky <bzbarsky@mit.edu> has denied Jesse Ruderman <jruderman@gmail.com>'s request for superreview: Bug 304388: Add hostname to title bar of windows that don't have location bars https://bugzilla.mozilla.org/show_bug.cgi?id=304388 Attachment 192787: update dveditz's patch to trunk https://bugzilla.mozilla.org/attachment.cgi?id=192787&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> This needs at least a similar patch for xpfe and a check on whether nsWebBrowser has similar issues, as well as testing of the nsCon...

superreview cancelled: [Bug 298677] regression: Vertical scrollbar draws over toolbar and tabs when location or search bar has focus during scrolling : [Attachment 188003] Patch
Javier Pedemonte (IBM) <jhpedemonte@gmail.com> has cancelled Simon Fraser <sfraser_bugs@smfr.org>'s request for superreview: Bug 298677: regression: Vertical scrollbar draws over toolbar and tabs when location or search bar has focus during scrolling https://bugzilla.mozilla.org/show_bug.cgi?id=298677 Attachment 188003: Patch https://bugzilla.mozilla.org/attachment.cgi?id=188003&action=edit ------- Additional Comments from Javier Pedemonte (IBM) <jhpedemonte@gmail.com> Unfortunately, I'm not a superreviewer, but I will review this patch anyway. + C...

superreview requested: [Bug 351289] Don't show the tab bar when using Ctrl-F4 on single tab (["Hide tab bar when only one tab is open"] pref is ignored) : [Attachment 236765] patch
Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 351289: Don't show the tab bar when using Ctrl-F4 on single tab (["Hide tab bar when only one tab is open"] pref is ignored) https://bugzilla.mozilla.org/show_bug.cgi?id=351289 Attachment 236765: patch https://bugzilla.mozilla.org/attachment.cgi?id=236765&action=edit ------- Additional Comments from Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com> If you show the tab bar: Ctrl+F4 => close tab ...

superreview denied: [Bug 351289] Don't show the tab bar when using Ctrl-F4 on single tab (["Hide tab bar when only one tab is open"] pref is ignored) : [Attachment 236765] patch
neil@parkwaycc.co.uk <neil@httl.net> has denied Chris Thomas (CTho) [formerly cst@andrew.cmu.edu] <cst@yecc.com>'s request for superreview: Bug 351289: Don't show the tab bar when using Ctrl-F4 on single tab (["Hide tab bar when only one tab is open"] pref is ignored) https://bugzilla.mozilla.org/show_bug.cgi?id=351289 Attachment 236765: patch https://bugzilla.mozilla.org/attachment.cgi?id=236765&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> 1. You shouldn't early return, you should reverse your conditi...

superreview requested: [Bug 78786] [FIX] Can't scroll URL bar history drop down with mouse wheel : [Attachment 153557] Patch A rev. 1 (must have patch from bug 97283 first)
Mats Palmgren <mats.palmgren@bredband.net> has asked David Baron <dbaron@dbaron.org> for superreview: Bug 78786: [FIX] Can't scroll URL bar history drop down with mouse wheel http://bugzilla.mozilla.org/show_bug.cgi?id=78786 Attachment 153557: Patch A rev. 1 (must have patch from bug 97283 first) http://bugzilla.mozilla.org/attachment.cgi?id=153557&action=edit ...

superreview granted: [Bug 288406] crash when dragging bookmark proxy icon (favicon) from Location Bar [@ 0x00000013 + OLE32.DLL
Boris Zbarsky <bzbarsky@mit.edu> has granted Robert O'Callahan (Novell) <roc@ocallahan.org>'s request for superreview: Bug 288406: crash when dragging bookmark proxy icon (favicon) from Location Bar [@ 0x00000013 + OLE32.DLL - nsDragService::StartInvokingDragSession] https://bugzilla.mozilla.org/show_bug.cgi?id=288406 Attachment 180533: fix? https://bugzilla.mozilla.org/attachment.cgi?id=180533&action=edit ...

superreview requested: [Bug 333623] about:blank's favicon draggable from location bar but not from tabs : [Attachment 224331] stops drag of icon if about:blank is the current URL
Chris Lawson <bugzilla@chrislawson.net> has asked Mike Pinkerton <mikepinkerton@mac.com> for superreview: Bug 333623: about:blank's favicon draggable from location bar but not from tabs https://bugzilla.mozilla.org/show_bug.cgi?id=333623 Attachment 224331: stops drag of icon if about:blank is the current URL https://bugzilla.mozilla.org/attachment.cgi?id=224331&action=edit ------- Additional Comments from Chris Lawson <bugzilla@chrislawson.net> sr=pink? cl ...

Web resources about - superreview cancelled: [Bug 340273] Can't drag proxy icons from tabs to location bar if focus is outside location bar : [Attachment 239703] This patch is the same as above, with an addition to fix a c - mozilla.dev.super-review

Resources last updated: 11/27/2015 6:56:13 PM