superreview cancelled: [Bug 336457] Mark selected search engine in the drop-down list : [Attachment 220880] Boldfaces selected engine name

Pam Greene (Google) <pamg.bugs@gmail.com> has cancelled Pam Greene (Google)
<pamg.bugs@gmail.com>'s request for superreview:
Bug 336457: Mark selected search engine in the drop-down list
https://bugzilla.mozilla.org/show_bug.cgi?id=336457

Attachment 220880: Boldfaces selected engine name
https://bugzilla.mozilla.org/attachment.cgi?id=220880&action=edit

------- Additional Comments from Pam Greene (Google) <pamg.bugs@gmail.com>
Using a class rather than an ID.  Also, because of some concurrent changes to
the patch for bug 335441, this patch is now independent of that one and works
just as it is.
0
bugzilla
5/5/2006 6:27:19 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
510 Views

Similar Articles

[PageSpeed] 55

Reply:

Similar Artilces:

superreview requested: [Bug 336457] Mark selected search engine in the drop-down list : [Attachment 220880] Boldfaces selected engine name
Pam Greene (Google) <pamg.bugs@gmail.com> has asked Ben Goodger (use ben at mozilla dot org for email) <bugs@bengoodger.com> for superreview: Bug 336457: Mark selected search engine in the drop-down list https://bugzilla.mozilla.org/show_bug.cgi?id=336457 Attachment 220880: Boldfaces selected engine name https://bugzilla.mozilla.org/attachment.cgi?id=220880&action=edit ------- Additional Comments from Pam Greene (Google) <pamg.bugs@gmail.com> The changes in this patch only do what they're described to do after the changes in the patch for bug 335441 are ap...

superreview requested: [Bug 336457] Mark selected search engine in the drop-down list : [Attachment 221002] Added comments explaining clearing of "selected" attribute
Pam Greene (Google) <pamg.bugs@gmail.com> has asked Ben Goodger (use ben at mozilla dot org for email) <bugs@bengoodger.com> for superreview: Bug 336457: Mark selected search engine in the drop-down list https://bugzilla.mozilla.org/show_bug.cgi?id=336457 Attachment 221002: Added comments explaining clearing of "selected" attribute https://bugzilla.mozilla.org/attachment.cgi?id=221002&action=edit ...

superreview granted: [Bug 336457] Mark selected search engine in the drop-down list : [Attachment 221002] Added comments explaining clearing of "selected" attribute
Ben Goodger (use ben at mozilla dot org for email) <bugs@bengoodger.com> has granted Pam Greene (Google) <pamg.bugs@gmail.com>'s request for superreview: Bug 336457: Mark selected search engine in the drop-down list https://bugzilla.mozilla.org/show_bug.cgi?id=336457 Attachment 221002: Added comments explaining clearing of "selected" attribute https://bugzilla.mozilla.org/attachment.cgi?id=221002&action=edit ------- Additional Comments from Ben Goodger (use ben at mozilla dot org for email) <bugs@bengoodger.com> sr=ben@mozilla.org ...

superreview cancelled: [Bug 336457] Mark selected search engine in the drop-down list : [Attachment 220889] Patch addressing Gavin's comments
Pam Greene (Google) <pamg.bugs@gmail.com> has cancelled Pam Greene (Google) <pamg.bugs@gmail.com>'s request for superreview: Bug 336457: Mark selected search engine in the drop-down list https://bugzilla.mozilla.org/show_bug.cgi?id=336457 Attachment 220889: Patch addressing Gavin's comments https://bugzilla.mozilla.org/attachment.cgi?id=220889&action=edit ...

superreview requested: [Bug 336457] Mark selected search engine in the drop-down list : [Attachment 220889] Patch addressing Gavin's comments
Pam Greene (Google) <pamg.bugs@gmail.com> has asked Ben Goodger (use ben at mozilla dot org for email) <bugs@bengoodger.com> for superreview: Bug 336457: Mark selected search engine in the drop-down list https://bugzilla.mozilla.org/show_bug.cgi?id=336457 Attachment 220889: Patch addressing Gavin's comments https://bugzilla.mozilla.org/attachment.cgi?id=220889&action=edit ------- Additional Comments from Pam Greene (Google) <pamg.bugs@gmail.com> Using a class rather than an ID. Also, because of some concurrent changes to the patch for bug 335441, this pat...

superreview cancelled: [Bug 258672] grey text in search box showing search engine name : [Attachment 220081] Patch to enable grayed search engine name within new binding structure
Joe Hughes <joe@retrovirus.com> has cancelled Joe Hughes <joe@retrovirus.com>'s request for superreview: Bug 258672: grey text in search box showing search engine name https://bugzilla.mozilla.org/show_bug.cgi?id=258672 Attachment 220081: Patch to enable grayed search engine name within new binding structure https://bugzilla.mozilla.org/attachment.cgi?id=220081&action=edit ...

superreview requested: [Bug 258672] grey text in search box showing search engine name : [Attachment 220081] Patch to enable grayed search engine name within new binding structure
Joe Hughes <joe@retrovirus.com> has asked Ben Goodger (use ben at mozilla dot org for email) <bugs@bengoodger.com> for superreview: Bug 258672: grey text in search box showing search engine name https://bugzilla.mozilla.org/show_bug.cgi?id=258672 Attachment 220081: Patch to enable grayed search engine name within new binding structure https://bugzilla.mozilla.org/attachment.cgi?id=220081&action=edit ...

superreview cancelled: [Bug 339735] Improve UI for adding search engines detected from <link rel...> : [Attachment 232055] Implements temporary search engines
Pam Greene (Google) <pamg.bugs@gmail.com> has cancelled Pam Greene (Google) <pamg.bugs@gmail.com>'s request for superreview: Bug 339735: Improve UI for adding search engines detected from <link rel...> https://bugzilla.mozilla.org/show_bug.cgi?id=339735 Attachment 232055: Implements temporary search engines https://bugzilla.mozilla.org/attachment.cgi?id=232055&action=edit ...

superreview cancelled: [Bug 258672] grey text in search box showing search engine name : [Attachment 220083] Same as previous but with better timeout binding
Gavin Sharp <gavin.sharp@gmail.com> has cancelled Joe Hughes <joe@retrovirus.com>'s request for superreview: Bug 258672: grey text in search box showing search engine name https://bugzilla.mozilla.org/show_bug.cgi?id=258672 Attachment 220083: Same as previous but with better timeout binding https://bugzilla.mozilla.org/attachment.cgi?id=220083&action=edit ------- Additional Comments from Gavin Sharp <gavin.sharp@gmail.com> Some things that don't work very well with this patch: - Ctrl+K to focus the search box (text remains in the box, but is un-greyed)...

superreview cancelled: [Bug 258672] grey text in search box showing search engine name : [Attachment 220191] Tidying up per Gavin's comments.
Joe Hughes <joe@retrovirus.com> has cancelled Joe Hughes <joe@retrovirus.com>'s request for superreview: Bug 258672: grey text in search box showing search engine name https://bugzilla.mozilla.org/show_bug.cgi?id=258672 Attachment 220191: Tidying up per Gavin's comments. https://bugzilla.mozilla.org/attachment.cgi?id=220191&action=edit ...

superreview cancelled: [Bug 335102] support search engine renaming : [Attachment 226444] rename engines
Gavin Sharp <gavin.sharp@gmail.com> has cancelled Joey Minta <jminta@gmail.com>'s request for superreview: Bug 335102: support search engine renaming https://bugzilla.mozilla.org/show_bug.cgi?id=335102 Attachment 226444: rename engines https://bugzilla.mozilla.org/attachment.cgi?id=226444&action=edit ------- Additional Comments from Gavin Sharp <gavin.sharp@gmail.com> >Index: browser/components/search/nsIBrowserSearchService.idl > /** >+ * Renames the engine to a new name. Note that this will throw in the case >+ * where the new na...

superreview requested: [Bug 219706] Using arrow keys to select drop down list box items selects two down or two up : [Attachment 156229] patch
Brian Ryner (IBM) <bryner@brianryner.com> has asked David Baron <dbaron@dbaron.org> for superreview: Bug 219706: Using arrow keys to select drop down list box items selects two down or two up http://bugzilla.mozilla.org/show_bug.cgi?id=219706 Attachment 156229: patch http://bugzilla.mozilla.org/attachment.cgi?id=156229&action=edit ------- Additional Comments from Brian Ryner (IBM) <bryner@brianryner.com> mkaply, this code should look familiar, you had a hand in it a few years ago to fix what sounds like a similar problem for os2. ...

superreview granted: [Bug 219706] Using arrow keys to select drop down list box items selects two down or two up : [Attachment 156229] patch
David Baron <dbaron@dbaron.org> has granted Brian Ryner (IBM) <bryner@brianryner.com>'s request for superreview: Bug 219706: Using arrow keys to select drop down list box items selects two down or two up http://bugzilla.mozilla.org/show_bug.cgi?id=219706 Attachment 156229: patch http://bugzilla.mozilla.org/attachment.cgi?id=156229&action=edit ------- Additional Comments from David Baron <dbaron@dbaron.org> sr=dbaron, although it seems to me that we shouldn't be allowing events to bubble at the widget level, ever. ...

superreview cancelled: [Bug 341577] Drag-and-drop of search engines on Mac looks ugly : [Attachment 226999] fix
Phil Ringnalda <philringnalda@gmail.com> has cancelled Phil Ringnalda <philringnalda@gmail.com>'s request for superreview: Bug 341577: Drag-and-drop of search engines on Mac looks ugly https://bugzilla.mozilla.org/show_bug.cgi?id=341577 Attachment 226999: fix https://bugzilla.mozilla.org/attachment.cgi?id=226999&action=edit ------- Additional Comments from Phil Ringnalda <philringnalda@gmail.com> Comments addressed, thanks! What using nsDragAndDrop buys us is http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/content/nsDragAndDr op.js&rev=...

Web resources about - superreview cancelled: [Bug 336457] Mark selected search engine in the drop-down list : [Attachment 220880] Boldfaces selected engine name - mozilla.dev.super-review

Resources last updated: 1/23/2016 10:05:47 AM