superreview cancelled: [Bug 335441] Change tiny drop-down in browser search box into a button/drop-down combo to the right of the search box : [Attachment 220886] Addressing more of Gavin's comments

Pam Greene (Google) <pamg.bugs@gmail.com> has cancelled Pam Greene (Google)
<pamg.bugs@gmail.com>'s request for superreview:
Bug 335441: Change tiny drop-down in browser search box into a button/drop-down
combo to the right of the search box
https://bugzilla.mozilla.org/show_bug.cgi?id=335441

Attachment 220886: Addressing more of Gavin's comments
https://bugzilla.mozilla.org/attachment.cgi?id=220886&action=edit

------- Additional Comments from Pam Greene (Google) <pamg.bugs@gmail.com>
(In reply to comment #33)
> +	if (textBox.value && !textBox.hasAttribute("disableautocomplete")) {

> Is this going to run afoul of the gray search engine text?  Maybe move the
> check for that above this, and use the textValue var in the test--then this
> conditional should handle the case.

Done.

> +		oncommand="this.parentNode.parentNode.parentNode
> +					  .handleSearchCommand(event);"

> Can these use _getParentSearchbar() (or similar)?

Moved them all into a handler, which allows direct access to the searchbox.
0
bugzilla
5/5/2006 10:34:24 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
733 Views

Similar Articles

[PageSpeed] 55

Reply:

Similar Artilces:

superreview requested: [Bug 335441] Change tiny drop-down in browser search box into a button/drop-down combo to the right of the search box : [Attachment 220886] Addressing more of Gavin's comments
Pam Greene (Google) <pamg.bugs@gmail.com> has asked Ben Goodger (use ben at mozilla dot org for email) <bugs@bengoodger.com> for superreview: Bug 335441: Change tiny drop-down in browser search box into a button/drop-down combo to the right of the search box https://bugzilla.mozilla.org/show_bug.cgi?id=335441 Attachment 220886: Addressing more of Gavin's comments https://bugzilla.mozilla.org/attachment.cgi?id=220886&action=edit ------- Additional Comments from Pam Greene (Google) <pamg.bugs@gmail.com> Gavin's convinced me that there's no need to re...

superreview cancelled: [Bug 335441] Change tiny drop-down in browser search box into a button/drop-down combo to the right of the search box : [Attachment 220883] Patch addressing Gavin's comments
Pam Greene (Google) <pamg.bugs@gmail.com> has cancelled Pam Greene (Google) <pamg.bugs@gmail.com>'s request for superreview: Bug 335441: Change tiny drop-down in browser search box into a button/drop-down combo to the right of the search box https://bugzilla.mozilla.org/show_bug.cgi?id=335441 Attachment 220883: Patch addressing Gavin's comments https://bugzilla.mozilla.org/attachment.cgi?id=220883&action=edit ...

superreview requested: [Bug 335441] Change tiny drop-down in browser search box into a button/drop-down combo to the right of the search box : [Attachment 220883] Patch addressing Gavin's comments
Pam Greene (Google) <pamg.bugs@gmail.com> has asked Ben Goodger (use ben at mozilla dot org for email) <bugs@bengoodger.com> for superreview: Bug 335441: Change tiny drop-down in browser search box into a button/drop-down combo to the right of the search box https://bugzilla.mozilla.org/show_bug.cgi?id=335441 Attachment 220883: Patch addressing Gavin's comments https://bugzilla.mozilla.org/attachment.cgi?id=220883&action=edit ------- Additional Comments from Pam Greene (Google) <pamg.bugs@gmail.com> Fixed all the problems Gavin noticed; thanks. > Any...

superreview cancelled: [Bug 335441] Change tiny drop-down in browser search box into a button/drop-down combo to the right of the search box : [Attachment 220877] Patch addressing Joe's comments
Pam Greene (Google) <pamg.bugs@gmail.com> has cancelled Pam Greene (Google) <pamg.bugs@gmail.com>'s request for superreview: Bug 335441: Change tiny drop-down in browser search box into a button/drop-down combo to the right of the search box https://bugzilla.mozilla.org/show_bug.cgi?id=335441 Attachment 220877: Patch addressing Joe's comments https://bugzilla.mozilla.org/attachment.cgi?id=220877&action=edit ------- Additional Comments from Pam Greene (Google) <pamg.bugs@gmail.com> Fixed all the problems Gavin noticed; thanks. > Any reason this ne...

superreview denied: [Bug 335441] Change tiny drop-down in browser search box into a button/drop-down combo to the right of the search box : [Attachment 220997] Patch addressing Joe's comments
Ben Goodger (use ben at mozilla dot org for email) <bugs@bengoodger.com> has denied Pam Greene (Google) <pamg.bugs@gmail.com>'s request for superreview: Bug 335441: Change tiny drop-down in browser search box into a button/drop-down combo to the right of the search box https://bugzilla.mozilla.org/show_bug.cgi?id=335441 Attachment 220997: Patch addressing Joe's comments https://bugzilla.mozilla.org/attachment.cgi?id=220997&action=edit ------- Additional Comments from Ben Goodger (use ben at mozilla dot org for email) <bugs@bengoodger.com> >Index: c...

superreview requested: [Bug 335441] Change tiny drop-down in browser search box into a button/drop-down combo to the right of the search box : [Attachment 220877] Patch addressing Joe's comments
Pam Greene (Google) <pamg.bugs@gmail.com> has asked Ben Goodger (use ben at mozilla dot org for email) <bugs@bengoodger.com> for superreview: Bug 335441: Change tiny drop-down in browser search box into a button/drop-down combo to the right of the search box https://bugzilla.mozilla.org/show_bug.cgi?id=335441 Attachment 220877: Patch addressing Joe's comments https://bugzilla.mozilla.org/attachment.cgi?id=220877&action=edit ------- Additional Comments from Pam Greene (Google) <pamg.bugs@gmail.com> Thanks. Changes made according to comments throughout; I&#...

superreview requested: [Bug 335441] Change tiny drop-down in browser search box into a button/drop-down combo to the right of the search box : [Attachment 220997] Patch addressing Joe's comments
Pam Greene (Google) <pamg.bugs@gmail.com> has asked Ben Goodger (use ben at mozilla dot org for email) <bugs@bengoodger.com> for superreview: Bug 335441: Change tiny drop-down in browser search box into a button/drop-down combo to the right of the search box https://bugzilla.mozilla.org/show_bug.cgi?id=335441 Attachment 220997: Patch addressing Joe's comments https://bugzilla.mozilla.org/attachment.cgi?id=220997&action=edit ------- Additional Comments from Pam Greene (Google) <pamg.bugs@gmail.com> (In reply to comment #33) > + if (textBox.value &&a...

superreview granted: [Bug 335441] Change tiny drop-down in browser search box into a button/drop-down combo to the right of the search box : [Attachment 221008] Patch with more class (see Ben's commen
Ben Goodger (use ben at mozilla dot org for email) <bugs@bengoodger.com> has granted Pam Greene (Google) <pamg.bugs@gmail.com>'s request for superreview: Bug 335441: Change tiny drop-down in browser search box into a button/drop-down combo to the right of the search box https://bugzilla.mozilla.org/show_bug.cgi?id=335441 Attachment 221008: Patch with more class (see Ben's comments) https://bugzilla.mozilla.org/attachment.cgi?id=221008&action=edit ------- Additional Comments from Ben Goodger (use ben at mozilla dot org for email) <bugs@bengoodger.com> ...

superreview requested: [Bug 335441] Change tiny drop-down in browser search box into a button/drop-down combo to the right of the search box : [Attachment 221008] Patch with more class (see Ben's comm
Pam Greene (Google) <pamg.bugs@gmail.com> has asked Ben Goodger (use ben at mozilla dot org for email) <bugs@bengoodger.com> for superreview: Bug 335441: Change tiny drop-down in browser search box into a button/drop-down combo to the right of the search box https://bugzilla.mozilla.org/show_bug.cgi?id=335441 Attachment 221008: Patch with more class (see Ben's comments) https://bugzilla.mozilla.org/attachment.cgi?id=221008&action=edit ...

superreview cancelled: [Bug 335441] Change tiny drop-down in browser search box into a button/drop-down combo to the right of the search box : [Attachment 220851] Consolidated implementation; no conte
Pam Greene (Google) <pamg.bugs@gmail.com> has cancelled Pam Greene (Google) <pamg.bugs@gmail.com>'s request for superreview: Bug 335441: Change tiny drop-down in browser search box into a button/drop-down combo to the right of the search box https://bugzilla.mozilla.org/show_bug.cgi?id=335441 Attachment 220851: Consolidated implementation; no context menu https://bugzilla.mozilla.org/attachment.cgi?id=220851&action=edit ------- Additional Comments from Pam Greene (Google) <pamg.bugs@gmail.com> Thanks. Changes made according to comments throughout; I'm...

superreview requested: [Bug 335441] Change tiny drop-down in browser search box into a button/drop-down combo to the right of the search box : [Attachment 220851] Consolidated implementation; no conte
Pam Greene (Google) <pamg.bugs@gmail.com> has asked Ben Goodger (use ben at mozilla dot org for email) <bugs@bengoodger.com> for superreview: Bug 335441: Change tiny drop-down in browser search box into a button/drop-down combo to the right of the search box https://bugzilla.mozilla.org/show_bug.cgi?id=335441 Attachment 220851: Consolidated implementation; no context menu https://bugzilla.mozilla.org/attachment.cgi?id=220851&action=edit ...

superreview cancelled: [Bug 258672] grey text in search box showing search engine name : [Attachment 220191] Tidying up per Gavin's comments.
Joe Hughes <joe@retrovirus.com> has cancelled Joe Hughes <joe@retrovirus.com>'s request for superreview: Bug 258672: grey text in search box showing search engine name https://bugzilla.mozilla.org/show_bug.cgi?id=258672 Attachment 220191: Tidying up per Gavin's comments. https://bugzilla.mozilla.org/attachment.cgi?id=220191&action=edit ...

superreview cancelled: [Bug 336457] Mark selected search engine in the drop-down list : [Attachment 220889] Patch addressing Gavin's comments
Pam Greene (Google) <pamg.bugs@gmail.com> has cancelled Pam Greene (Google) <pamg.bugs@gmail.com>'s request for superreview: Bug 336457: Mark selected search engine in the drop-down list https://bugzilla.mozilla.org/show_bug.cgi?id=336457 Attachment 220889: Patch addressing Gavin's comments https://bugzilla.mozilla.org/attachment.cgi?id=220889&action=edit ...

superreview granted: [Bug 335443] Support autodetection --> option of adding search engine definitions to browser search box : [Attachment 221037] Patch addressing Ben's comments
Ben Goodger (use ben at mozilla dot org for email) <bugs@bengoodger.com> has granted Pam Greene (Google) <pamg.bugs@gmail.com>'s request for superreview: Bug 335443: Support autodetection --> option of adding search engine definitions to browser search box https://bugzilla.mozilla.org/show_bug.cgi?id=335443 Attachment 221037: Patch addressing Ben's comments https://bugzilla.mozilla.org/attachment.cgi?id=221037&action=edit ------- Additional Comments from Ben Goodger (use ben at mozilla dot org for email) <bugs@bengoodger.com> r+a=ben@mozilla.org ...

Web resources about - superreview cancelled: [Bug 335441] Change tiny drop-down in browser search box into a button/drop-down combo to the right of the search box : [Attachment 220886] Addressing more of Gavin's comments - mozilla.dev.super-review

Resources last updated: 11/25/2015 9:56:43 AM