superreview cancelled: [Bug 182758] freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom : [Attachment 236154] Update with feedback from Nelson and Wan-Teh

Julien Pierre <julien.pierre.bugs@sun.com> has cancelled Julien Pierre
<julien.pierre.bugs@sun.com>'s request for superreview:
Bug 182758: freebl PRNG hashes netstat and /dev/urandom data rather than just
using /dev/urandom
https://bugzilla.mozilla.org/show_bug.cgi?id=182758

Attachment 236154: Update with feedback from Nelson and Wan-Teh
https://bugzilla.mozilla.org/attachment.cgi?id=236154&action=edit

------- Additional Comments from Julien Pierre <julien.pierre.bugs@sun.com>
This patch contains several changes :
1) More comments
2) CollectEntropy and RNG_kstat are both changed to return a SECStatus . This
is to ease future work in bug 350798 to check for success
3) CollectEntropy has an extra PRUint32 *total_fed argument which gets
incremented
4) RNG_kstat has an extra PRUInt32* fed argument to return the number of bytes
of entropy that it generated and fed to the RNG
5) CollectEntropy now only feeds data to the RNG if the buffer is full, and
will never pass a zero length to RNG_RandomUpdate
6) CollectEntropy local variable buffered renamed to processed
7) CollectEntropy argument entropy_collected renamed to entropy_buffered. Same
for RNG_kstat local
0
bugzilla
9/1/2006 12:47:14 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
599 Views

Similar Articles

[PageSpeed] 48

Reply:

Similar Artilces:

superreview requested: [Bug 182758] freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom : [Attachment 236154] Update with feedback from Nelson and Wan-Teh
Julien Pierre <julien.pierre.bugs@sun.com> has asked Wan-Teh Chang <wtchang@redhat.com> for superreview: Bug 182758: freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom https://bugzilla.mozilla.org/show_bug.cgi?id=182758 Attachment 236154: Update with feedback from Nelson and Wan-Teh https://bugzilla.mozilla.org/attachment.cgi?id=236154&action=edit ------- Additional Comments from Julien Pierre <julien.pierre.bugs@sun.com> - remove kprintf statements - rename max_entropy_len to max_entropy_buf_len - initialize buffered to zer...

superreview cancelled: [Bug 182758] freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom : [Attachment 235586] Update
Nelson Bolyard <nelson@bolyard.com> has cancelled Julien Pierre <julien.pierre.bugs@sun.com>'s request for superreview: Bug 182758: freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom https://bugzilla.mozilla.org/show_bug.cgi?id=182758 Attachment 235586: Update https://bugzilla.mozilla.org/attachment.cgi?id=235586&action=edit ------- Additional Comments from Nelson Bolyard <nelson@bolyard.com> I have some minor quibbles with this patch. 1) rather than seeing all the new code be "ifdef solaris" and "ifndef ...

superreview denied: [Bug 182758] freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom : [Attachment 235522] On Solaris, use only /dev/urandom if it is available. If not
Wan-Teh Chang <wtchang@redhat.com> has denied Julien Pierre <julien.pierre.bugs@sun.com>'s request for superreview: Bug 182758: freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom https://bugzilla.mozilla.org/show_bug.cgi?id=182758 Attachment 235522: On Solaris, use only /dev/urandom if it is available. If not, use libkstat https://bugzilla.mozilla.org/attachment.cgi?id=235522&action=edit ------- Additional Comments from Wan-Teh Chang <wtchang@redhat.com> These are just some minor problems. But since there are many, I wa...

superreview requested: [Bug 182758] freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom : [Attachment 235522] On Solaris, use only /dev/urandom if it is available. If
Julien Pierre <julien.pierre.bugs@sun.com> has asked Wan-Teh Chang <wtchang@redhat.com> for superreview: Bug 182758: freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom https://bugzilla.mozilla.org/show_bug.cgi?id=182758 Attachment 235522: On Solaris, use only /dev/urandom if it is available. If not, use libkstat https://bugzilla.mozilla.org/attachment.cgi?id=235522&action=edit ------- Additional Comments from Julien Pierre <julien.pierre.bugs@sun.com> In the libkstat case, I am feeding all kernel statistics to the PRNG, 4 KB ...

superreview granted: [Bug 182758] freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom : [Attachment 236342] update
Wan-Teh Chang <wtchang@redhat.com> has granted Julien Pierre <julien.pierre.bugs@sun.com>'s request for superreview: Bug 182758: freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom https://bugzilla.mozilla.org/show_bug.cgi?id=182758 Attachment 236342: update https://bugzilla.mozilla.org/attachment.cgi?id=236342&action=edit ------- Additional Comments from Wan-Teh Chang <wtchang@redhat.com> r=wtc. Please remove the 4 extraneous semicolons after closing curly braces. Just search for "};" in the file and remove ...

superreview requested: [Bug 182758] freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom : [Attachment 235586] Update
Julien Pierre <julien.pierre.bugs@sun.com> has asked Nelson Bolyard <nelson@bolyard.com> for superreview: Bug 182758: freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom https://bugzilla.mozilla.org/show_bug.cgi?id=182758 Attachment 235586: Update https://bugzilla.mozilla.org/attachment.cgi?id=235586&action=edit ------- Additional Comments from Julien Pierre <julien.pierre.bugs@sun.com> Wan-Teh, This was written from scratch, it wasn't sample code. I switched from assert to PORT_Assert, as well as from malloc/free to ...

superreview requested: [Bug 182758] freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom : [Attachment 236342] update
Julien Pierre <julien.pierre.bugs@sun.com> has asked Wan-Teh Chang <wtchang@redhat.com> for superreview: Bug 182758: freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom https://bugzilla.mozilla.org/show_bug.cgi?id=182758 Attachment 236342: update https://bugzilla.mozilla.org/attachment.cgi?id=236342&action=edit ------- Additional Comments from Julien Pierre <julien.pierre.bugs@sun.com> This patch contains several changes : 1) More comments 2) CollectEntropy and RNG_kstat are both changed to return a SECStatus . This is to ea...

superreview cancelled: [Bug 115951] freebl dynamic library is never unloaded by libsoftoken or libssl. Also tiny one-time leak in freebl's loader.c : [Attachment 239727] Incorporate Wan-Teh's feedback
Julien Pierre <julien.pierre.bugs@sun.com> has cancelled Julien Pierre <julien.pierre.bugs@sun.com>'s request for superreview: Bug 115951: freebl dynamic library is never unloaded by libsoftoken or libssl. Also tiny one-time leak in freebl's loader.c https://bugzilla.mozilla.org/show_bug.cgi?id=115951 Attachment 239727: Incorporate Wan-Teh's feedback https://bugzilla.mozilla.org/attachment.cgi?id=239727&action=edit ------- Additional Comments from Julien Pierre <julien.pierre.bugs@sun.com> 1) I decided to still add the check for blLib, because the ...

superreview denied: [Bug 302550] JSS library needs to be ported to Solaris/Linux on AMD64 : [Attachment 193985] Updated changes to files based on review feedback from Wan-Teh
Wan-Teh Chang <wtchang@redhat.com> has denied Sandeep Konchady <Sandeep.Konchady@Sun.COM>'s request for superreview: Bug 302550: JSS library needs to be ported to Solaris/Linux on AMD64 https://bugzilla.mozilla.org/show_bug.cgi?id=302550 Attachment 193985: Updated changes to files based on review feedback from Wan-Teh https://bugzilla.mozilla.org/attachment.cgi?id=193985&action=edit ------- Additional Comments from Wan-Teh Chang <wtchang@redhat.com> Sandeep, Some of the changes in this patch are wrong. 1. coreconf/import.pl Just remove the $var{ZI...

superreview requested: [Bug 302550] JSS library needs to be ported to Solaris/Linux on AMD64 : [Attachment 193985] Updated changes to files based on review feedback from Wan-Teh
Sandeep Konchady <Sandeep.Konchady@Sun.COM> has asked Wan-Teh Chang <wtchang@redhat.com> for superreview: Bug 302550: JSS library needs to be ported to Solaris/Linux on AMD64 https://bugzilla.mozilla.org/show_bug.cgi?id=302550 Attachment 193985: Updated changes to files based on review feedback from Wan-Teh https://bugzilla.mozilla.org/attachment.cgi?id=193985&action=edit ------- Additional Comments from Sandeep Konchady <Sandeep.Konchady@Sun.COM> 1. coreconf/import.pl Removed $var{ZIP} 2. coreconf/jdk.mk Replaced spaces with tabs to stick to the ex...

superreview cancelled: [Bug 303508] Add freebl shared libs that do only 64-bit integer math : [Attachment 195950] Additional patch for lib/freebl from Wan-Teh, v2
Nelson Bolyard <nelson@bolyard.com> has cancelled Wan-Teh Chang <wtchang@redhat.com>'s request for superreview: Bug 303508: Add freebl shared libs that do only 64-bit integer math https://bugzilla.mozilla.org/show_bug.cgi?id=303508 Attachment 195950: Additional patch for lib/freebl from Wan-Teh, v2 https://bugzilla.mozilla.org/attachment.cgi?id=195950&action=edit ------- Additional Comments from Nelson Bolyard <nelson@bolyard.com> r=nelson. Saul has some additional review comments coming soon, I think. Suggestion: In manifest.mn, instead of adding 5 ne...

superreview requested: [Bug 115951] freebl dynamic library is never unloaded by libsoftoken or libssl. Also tiny one-time leak in freebl's loader.c : [Attachment 239727] Incorporate Wan-Teh's feedback
Julien Pierre <julien.pierre.bugs@sun.com> has asked Wan-Teh Chang <wtchang@redhat.com> for superreview: Bug 115951: freebl dynamic library is never unloaded by libsoftoken or libssl. Also tiny one-time leak in freebl's loader.c https://bugzilla.mozilla.org/show_bug.cgi?id=115951 Attachment 239727: Incorporate Wan-Teh's feedback https://bugzilla.mozilla.org/attachment.cgi?id=239727&action=edit ------- Additional Comments from Julien Pierre <julien.pierre.bugs@sun.com> 1) This patch no longer has the freebl init callback mechanism that the previous one...

Merging dev-gaia and dev-b2g into dev-fxos
--001a113ce93ebce35d051e4c0c73 Content-Type: text/plain; charset=UTF-8 Hello people of Firefox OS, After a discussion we have decided that the distinction between dev-gaia and dev-b2g mailing lists is not enough to warrant maintaining two lists. So we are deprecating both in favor of dev-fxos. So if you are subscribed to one of the aforementioned lists, you will be subscribed to the new dev-fxos list and we will shortly be decommissioning dev-gaia and dev-b2g. Thanks! Michael --001a113ce93ebce35d051e4c0c73 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: qu...

Merging dev-gaia and dev-b2g into dev-fxos
--001a113ce93ebce35d051e4c0c73 Content-Type: text/plain; charset=UTF-8 Hello people of Firefox OS, After a discussion we have decided that the distinction between dev-gaia and dev-b2g mailing lists is not enough to warrant maintaining two lists. So we are deprecating both in favor of dev-fxos. So if you are subscribed to one of the aforementioned lists, you will be subscribed to the new dev-fxos list and we will shortly be decommissioning dev-gaia and dev-b2g. Thanks! Michael --001a113ce93ebce35d051e4c0c73 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: qu...

Web resources about - superreview cancelled: [Bug 182758] freebl PRNG hashes netstat and /dev/urandom data rather than just using /dev/urandom : [Attachment 236154] Update with feedback from Nelson and Wan-Teh - mozilla.dev.super-review

Resources last updated: 1/7/2016 9:13:03 PM