superreview canceled: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 310268] SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2.5

zug_treno@yahoo.com has canceled zug_treno@yahoo.com's request for superreview:
Bug 93390: [RFE]"Block images from this server" should identify "this server"
https://bugzilla.mozilla.org/show_bug.cgi?id=93390

Attachment 310268: SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2.5
https://bugzilla.mozilla.org/attachment.cgi?id=310268&action=edit

------- Additional Comments from zug_treno@yahoo.com
(In reply to comment #40)
> I don't like this. I think we should hide the menuitems if we can't get a 
> host.

OK, the menuitems aren't shown if we can't get a host.
 
> >+blockImage=Block Images from %S
> >+unblockImage=Unblock Images from %S
> You should also remove the old strings.

The two accesskey strings in imageContextOverlay.dtd seem to be unused, should
those (and maybe the then empty file) also be removed?
0
bugzilla
3/30/2008 8:47:02 PM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
571 Views

Similar Articles

[PageSpeed] 41

Reply:

Similar Artilces:

superreview requested: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 310268] SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2.5
zug_treno@yahoo.com has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this serve= r" https://bugzilla.mozilla.org/show_bug.cgi?id=3D93390 Attachment 310268: SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2.5 https://bugzilla.mozilla.org/attachment.cgi?id=3D310268&action=3Dedit ------- Additional Comments from zug_treno@yahoo.com (In reply to comment #40)=0D > I don't like this. I think we should hide the menuitems if we can't get a= =0D > host.=0...

superreview requested: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 307048] SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2
zug_treno@yahoo.com has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this server" https://bugzilla.mozilla.org/show_bug.cgi?id=93390 Attachment 307048: SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2 https://bugzilla.mozilla.org/attachment.cgi?id=307048&action=edit ...

superreview denied: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 307048] SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2
neil@parkwaycc.co.uk <neil@httl.net> has denied zug_treno@yahoo.com's reque= st for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this serve= r" https://bugzilla.mozilla.org/show_bug.cgi?id=3D93390 Attachment 307048: SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2 https://bugzilla.mozilla.org/attachment.cgi?id=3D307048&action=3Dedit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> >+ if (scheme =3D=3D "file") {=0D >+ serverLabel =3D "localhost&qu...

superreview canceled: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 312640] SeaMonkey 2.0a1pre version of Mogens Isager's patch v.3 (ready for sr)
neil@parkwaycc.co.uk <neil@httl.net> has canceled zug_treno@yahoo.com's request for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this server" https://bugzilla.mozilla.org/show_bug.cgi?id=93390 Attachment 312640: SeaMonkey 2.0a1pre version of Mogens Isager's patch v.3 (ready for sr) https://bugzilla.mozilla.org/attachment.cgi?id=312640&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> So, if you could fix the code to only show the menuitem for schemes with hosts, and while y...

superreview requested: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 312640] SeaMonkey 2.0a1pre version of Mogens Isager's patch v.3 (ready for sr)
zug_treno@yahoo.com has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this server" https://bugzilla.mozilla.org/show_bug.cgi?id=93390 Attachment 312640: SeaMonkey 2.0a1pre version of Mogens Isager's patch v.3 (ready for sr) https://bugzilla.mozilla.org/attachment.cgi?id=312640&action=edit ------- Additional Comments from zug_treno@yahoo.com (In reply to comment #40) > I don't like this. I think we should hide the menuitems if we can't get a > host. OK...

superreview granted: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 327455] v5
neil@parkwaycc.co.uk <neil@httl.net> has granted Vlado Valastiak (wladow, Mozilla.sk) <wladow@gmail.com>'s request for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this serve= r" https://bugzilla.mozilla.org/show_bug.cgi?id=3D93390 Attachment 327455: v5 https://bugzilla.mozilla.org/attachment.cgi?id=3D327455&action=3Dedit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> Wow, that code looks much better now :-)=0D =0D >- gContextMenu.showItem=0D >- ("context-blocki...

superreview requested: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 327455] v5
Vlado Valastiak (wladow, Mozilla.sk) <wladow@gmail.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this server" https://bugzilla.mozilla.org/show_bug.cgi?id=93390 Attachment 327455: v5 https://bugzilla.mozilla.org/attachment.cgi?id=327455&action=edit ------- Additional Comments from Vlado Valastiak (wladow, Mozilla.sk) <wladow@gmail.com> This adds separate accesskeys and as requested changes the way how we hide/unhide both menu-items (hide both first, unh...

superreview denied: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 327181] v4
neil@parkwaycc.co.uk <neil@httl.net> has denied Vlado Valastiak (wladow, Mozilla.sk) <wladow@gmail.com>'s request for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this server" https://bugzilla.mozilla.org/show_bug.cgi?id=93390 Attachment 327181: v4 https://bugzilla.mozilla.org/attachment.cgi?id=327181&action=edit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> OK, so this patch is almost ready, but I checked with L10N and we do want separate accesskeys for block and unblock. While y...

superreview requested: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 327636] for checkin
Vlado Valastiak (wladow, Mozilla.sk) <wladow@gmail.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this server" https://bugzilla.mozilla.org/show_bug.cgi?id=93390 Attachment 327636: for checkin https://bugzilla.mozilla.org/attachment.cgi?id=327636&action=edit ------- Additional Comments from Vlado Valastiak (wladow, Mozilla.sk) <wladow@gmail.com> This patch compared to previous: 1) removes isBlockingImages() completely 2) uses serverLabel only (gets rid ...

superreview granted: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 327636] for checkin
neil@parkwaycc.co.uk <neil@httl.net> has granted Vlado Valastiak (wladow, Mozilla.sk) <wladow@gmail.com>'s request for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this server" https://bugzilla.mozilla.org/show_bug.cgi?id=93390 Attachment 327636: for checkin https://bugzilla.mozilla.org/attachment.cgi?id=327636&action=edit ...

superreview requested: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 327181] v4
Vlado Valastiak (wladow, Mozilla.sk) <wladow@gmail.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 93390: [RFE]"Block images from this server" should identify "this server" https://bugzilla.mozilla.org/show_bug.cgi?id=93390 Attachment 327181: v4 https://bugzilla.mozilla.org/attachment.cgi?id=327181&action=edit ------- Additional Comments from Vlado Valastiak (wladow, Mozilla.sk) <wladow@gmail.com> This is updated v3 patch with neil's comments addressed: 1) shows menu-item only for schemes with hosts (FX appro...

superreview cancelled: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only)
Serge GAUTHERIE <gautheri@noos.fr> has cancelled Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ...

superreview requested: [Bug 228780] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") : [Attachment 146639] (Bv1b-r) <morkParser.cpp> (for review only) #2
Serge GAUTHERIE <gautheri@noos.fr> has asked Seth Spitzer <sspitzer@mozilla.org> for superreview: Bug 228780: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 2/2: "with function call") http://bugzilla.mozilla.org/show_bug.cgi?id=228780 Attachment 146639: (Bv1b-r) <morkParser.cpp> (for review only) http://bugzilla.mozilla.org/attachment.cgi?id=146639&action=edit ...

superreview cancelled: [Bug 90906] Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1/2: "with no function call") : [Attachment 174788] (Tv1) transformiix/xpath #2
Peter Van der Beken <peterv@propagandism.org> has cancelled Serge GAUTHERIE <gautheri@noos.fr>'s request for superreview: Bug 90906: Fix all "Unused variable '[...]'" 'Build Warnings' (Part 1/2: "with no function call") https://bugzilla.mozilla.org/show_bug.cgi?id=90906 Attachment 174788: (Tv1) transformiix/xpath https://bugzilla.mozilla.org/attachment.cgi?id=174788&action=edit ------- Additional Comments from Peter Van der Beken <peterv@propagandism.org> Code was rewritten as part of the fix for bug 278981. ...

Web resources about - superreview canceled: [Bug 93390] [RFE]"Block images from this server" should identify "this server" : [Attachment 310268] SeaMonkey 2.0a1pre version of Mogens Isager's patch v.2.5 - mozilla.dev.super-review

Resources last updated: 12/3/2015 8:05:52 AM