superreview canceled: [Bug 444209] Filter only selected messages in a folder : [Attachment 328572] Filter Selected Messages UI - Take 2

Jeff Beckley <beckley@qualcomm.com> has canceled Jeff Beckley
<beckley@qualcomm.com>'s request for superreview:
Bug 444209: Filter only selected messages in a folder
https://bugzilla.mozilla.org/show_bug.cgi?id=3D444209

Attachment 328572: Filter Selected Messages UI - Take 2
https://bugzilla.mozilla.org/attachment.cgi?id=3D328572&action=3Dedit

------- Additional Comments from Jeff Beckley <beckley@qualcomm.com>
Here's a new patch that addresses Neil's comments.  The code to apply filte=
rs
manually can't deal with messages living in multiple folders, so I just hav=
e it
use the logic for the Run Filters on Folder menu item, which will disabled =
the
menu item for virtual folders.	I also added a check for preventing the
addition of null message headers to the list so that the crash won't occur =
if
that happens again.=
0
bugzilla
7/10/2008 2:40:21 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
636 Views

Similar Articles

[PageSpeed] 6

Reply:

Similar Artilces:

superreview canceled: [Bug 444209] Filter only selected messages in a folder : [Attachment 328569] Filter Selected Messages UI
Jeff Beckley <beckley@qualcomm.com> has canceled Jeff Beckley <beckley@qualcomm.com>'s request for superreview: Bug 444209: Filter only selected messages in a folder https://bugzilla.mozilla.org/show_bug.cgi?id=444209 Attachment 328569: Filter Selected Messages UI https://bugzilla.mozilla.org/attachment.cgi?id=328569&action=edit ------- Additional Comments from Jeff Beckley <beckley@qualcomm.com> Some of my local changes didn't get included in the initial patch. Now they are in there. ...

superreview requested: [Bug 444209] Filter only selected messages in a folder : [Attachment 328569] Filter Selected Messages UI
Jeff Beckley <beckley@qualcomm.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 444209: Filter only selected messages in a folder https://bugzilla.mozilla.org/show_bug.cgi?id=3D444209 Attachment 328569: Filter Selected Messages UI https://bugzilla.mozilla.org/attachment.cgi?id=3D328569&action=3Dedit ------- Additional Comments from Jeff Beckley <beckley@qualcomm.com> Some Classic Eudora users manage their mail by using the ability to manually filter specific messages (e.g. when the message has been dealt with by the user). This patch g...

superreview canceled: [Bug 444209] Filter only selected messages in a folder : [Attachment 328805] New patch addressing Neil's comments
Jeff Beckley <beckley@qualcomm.com> has canceled Jeff Beckley <beckley@qualcomm.com>'s request for superreview: Bug 444209: Filter only selected messages in a folder https://bugzilla.mozilla.org/show_bug.cgi?id=444209 Attachment 328805: New patch addressing Neil's comments https://bugzilla.mozilla.org/attachment.cgi?id=328805&action=edit ------- Additional Comments from Jeff Beckley <beckley@qualcomm.com> Here's fixes based on Neil's latest comments: - Menu item is only enabled when there is at least one "real" (i.e. non-dummy) messa...

superreview granted: [Bug 444209] Filter only selected messages in a folder : [Attachment 334502] Final patch
Jeff Beckley <beckley@qualcomm.com> has granted superreview: Bug 444209: Filter only selected messages in a folder https://bugzilla.mozilla.org/show_bug.cgi?id=444209 Attachment 334502: Final patch https://bugzilla.mozilla.org/attachment.cgi?id=334502&action=edit ------- Additional Comments from Jeff Beckley <beckley@qualcomm.com> Addressed Karsten's review comments. All done now, and ready for check in. Continuing r=mnyromyr, sr=neil. ...

superreview granted: [Bug 444209] Filter only selected messages in a folder : [Attachment 330086] Neil's remaining comments
Jeff Beckley <beckley@qualcomm.com> has granted superreview: Bug 444209: Filter only selected messages in a folder https://bugzilla.mozilla.org/show_bug.cgi?id=444209 Attachment 330086: Neil's remaining comments https://bugzilla.mozilla.org/attachment.cgi?id=330086&action=edit ------- Additional Comments from Jeff Beckley <beckley@qualcomm.com> Fixes for small issues that Neil pointed out. Karsten: Where art thou? ...

superreview requested: [Bug 444209] Filter only selected messages in a folder : [Attachment 329967] Changes for Neil's latest comments
Jeff Beckley <beckley@qualcomm.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 444209: Filter only selected messages in a folder https://bugzilla.mozilla.org/show_bug.cgi?id=444209 Attachment 329967: Changes for Neil's latest comments https://bugzilla.mozilla.org/attachment.cgi?id=329967&action=edit ------- Additional Comments from Jeff Beckley <beckley@qualcomm.com> Here's fixes based on Neil's latest comments: - Menu item is only enabled when there is at least one "real" (i.e. non-dummy) message selected - Sel...

superreview granted: [Bug 444209] Filter only selected messages in a folder : [Attachment 329967] Changes for Neil's latest comments
neil@parkwaycc.co.uk <neil@httl.net> has granted Jeff Beckley <beckley@qualcomm.com>'s request for superreview: Bug 444209: Filter only selected messages in a folder https://bugzilla.mozilla.org/show_bug.cgi?id=3D444209 Attachment 329967: Changes for Neil's latest comments https://bugzilla.mozilla.org/attachment.cgi?id=3D329967&action=3Dedit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> > case "cmd_reload":=0D >+ case "cmd_applyFiltersToSelection":=0D >+ if (command =3D=3D "cmd_applyFiltersTo...

superreview requested: [Bug 444209] Filter only selected messages in a folder : [Attachment 328805] New patch addressing Neil's comments
Jeff Beckley <beckley@qualcomm.com> has asked neil@parkwaycc.co.uk <neil@httl.net> for superreview: Bug 444209: Filter only selected messages in a folder https://bugzilla.mozilla.org/show_bug.cgi?id=3D444209 Attachment 328805: New patch addressing Neil's comments https://bugzilla.mozilla.org/attachment.cgi?id=3D328805&action=3Dedit ------- Additional Comments from Jeff Beckley <beckley@qualcomm.com> Here's a new patch that addresses Neil's comments. The code to apply filte= rs manually can't deal with messages living in multiple folders, so I...

superreview canceled: [Bug 260422] Enable/disable message filter makes filter list jump to the top of the list : [Attachment 198932] patch to fix this bug and FilterListDialog UI improvement
David Bienvenu <bienvenu@nventure.com> has canceled David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 260422: Enable/disable message filter makes filter list jump to the top of the list https://bugzilla.mozilla.org/show_bug.cgi?id=260422 Attachment 198932: patch to fix this bug and FilterListDialog UI improvement https://bugzilla.mozilla.org/attachment.cgi?id=198932&action=edit ------- Additional Comments from David Bienvenu <bienvenu@nventure.com> clearing requests, obsoleting - jminta's work in bug 422474 has fixed this - yay! ...

superreview cancelled: [Bug 226604] crash closing message compose window (with UI button)/message filter dialog : [Attachment 136216] supplemental patch
timeless@myrealbox.com <timeless@bemail.org> has cancelled timeless@myrealbox.com <timeless@bemail.org>'s request for superreview: Bug 226604: crash closing message compose window (with UI button)/message filter dialog http://bugzilla.mozilla.org/show_bug.cgi?id=226604 Attachment 136216: supplemental patch http://bugzilla.mozilla.org/attachment.cgi?id=136216&action=edit ...

superreview cancelled: [Bug 183419] Message Filter dialog and Search dialogs (Message, Address) need close buttons : [Attachment 202828] Allow accel-w to close the filter & search dialogs (SeaMonkey
Mark Banner <bugzilla@standard8.demon.co.uk> has cancelled Mark Banner <bugzilla@standard8.demon.co.uk>'s request for superreview: Bug 183419: Message Filter dialog and Search dialogs (Message, Address) need close buttons https://bugzilla.mozilla.org/show_bug.cgi?id=183419 Attachment 202828: Allow accel-w to close the filter & search dialogs (SeaMonkey version) https://bugzilla.mozilla.org/attachment.cgi?id=202828&action=edit ------- Additional Comments from Mark Banner <bugzilla@standard8.demon.co.uk> Opps, cancelling reviews - looking at Thunderbird...

superreview requested: [Bug 212625] drop-down box doesn't open after selecting customize header in Filter rules/Search messages dialogs : [Attachment 135412] Ugly hack #2
neil@parkwaycc.co.uk <neil.parkwaycc.co.uk@myrealbox.com> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 212625: drop-down box doesn't open after selecting customize header in Filter rules/Search messages dialogs http://bugzilla.mozilla.org/show_bug.cgi?id=212625 Attachment 135412: Ugly hack http://bugzilla.mozilla.org/attachment.cgi?id=135412&action=edit ...

superreview granted: [Bug 276812] If you define a message filter with Message Filter window open, filter doesn't appear. : [Attachment 170141] Patch to fix regression for Mailnews and TB
David Bienvenu <bienvenu@nventure.com> has granted Mark Banner <mark@standard8.demon.co.uk>'s request for superreview: Bug 276812: If you define a message filter with Message Filter window open, filter doesn't appear. https://bugzilla.mozilla.org/show_bug.cgi?id=276812 Attachment 170141: Patch to fix regression for Mailnews and TB https://bugzilla.mozilla.org/attachment.cgi?id=170141&action=edit ...

superreview requested: [Bug 276812] If you define a message filter with Message Filter window open, filter doesn't appear. : [Attachment 170141] Patch to fix regression for Mailnews and TB
Mark Banner <mark@standard8.demon.co.uk> has asked David Bienvenu <bienvenu@nventure.com> for superreview: Bug 276812: If you define a message filter with Message Filter window open, filter doesn't appear. https://bugzilla.mozilla.org/show_bug.cgi?id=276812 Attachment 170141: Patch to fix regression for Mailnews and TB https://bugzilla.mozilla.org/attachment.cgi?id=170141&action=edit ------- Additional Comments from Mark Banner <mark@standard8.demon.co.uk> This patch adds the missing changes from preselectedFolder to folder for both mailnews and TB. Going...

superreview granted: [Bug 271988] compacting folder other than selected one clears message and thread panes : [Attachment 330519] only refresh selection for non-imap folders
neil@parkwaycc.co.uk <neil@httl.net> has granted David Bienvenu <bienvenu@nventure.com>'s request for superreview: Bug 271988: compacting folder other than selected one clears message and th= read panes https://bugzilla.mozilla.org/show_bug.cgi?id=3D271988 Attachment 330519: only refresh selection for non-imap folders https://bugzilla.mozilla.org/attachment.cgi?id=3D330519&action=3Dedit ------- Additional Comments from neil@parkwaycc.co.uk <neil@httl.net> IMHO it still sucks that the DB view can't be updated invisibly - it's not = as if the list...

Web resources about - superreview canceled: [Bug 444209] Filter only selected messages in a folder : [Attachment 328572] Filter Selected Messages UI - Take 2 - mozilla.dev.super-review

Biz & Finance Magazines
Australian magazine subscriptions price comparison.

Ehsan Akhgari
Bugzilla is an essential tool to the working process of Mozilla, and many of us spend a good portion of their day in Bugzilla. The Bugzilla Tweaks ...

Resources last updated: 11/28/2015 1:18:56 AM