superreview canceled: [Bug 426776] If a folder contains a 'broken' symbolic link, you can't navigate to it in Firefox using the file:/// URL. : [Attachment 313548] Patch rev. 1

Christian :Biesinger <cbiesinger@gmail.com> has canceled Mats Palmgren
<mats.palmgren@bredband.net>'s request for superreview:
Bug 426776: If a folder contains a 'broken' symbolic link, you can't naviga=
te
to it in Firefox using the file:/// URL.
https://bugzilla.mozilla.org/show_bug.cgi?id=3D426776

Attachment 313548: Patch rev. 1
https://bugzilla.mozilla.org/attachment.cgi?id=3D313548&action=3Dedit

------- Additional Comments from Christian :Biesinger <cbiesinger@gmail.com>
+  int err =3D lstat((char*)path, &stats);=0D
=0D
that cast seems unnecessay, remove it.=0D
=0D
+  if (err =3D=3D 0) {=0D
=0D
I think it would be better to first check for failure and then return, to a=
void
some indentation in the success case.=0D
=0D
+    return err =3D=3D ENOENT || err =3D=3D ENOTDIR ?=0D
+      NS_ERROR_FILE_NOT_FOUND : NS_ERROR_FAILURE;=0D
=0D
err is -1 in case of failure, you need to check errno.=0D
=0D
And a unit test would be really nice.=0D
=0D
-		     if (NS_FAILED(rv)) return rv; =0D
+		     if (NS_FAILED(rv)) return rv;=0D
		     if (isLink) {=0D
=0D
shouldn't this also be changed to if (NS_SUCCEEDED(rv) && isLink)?=
0
bugzilla
4/5/2008 10:51:15 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
538 Views

Similar Articles

[PageSpeed] 45

Reply:

Similar Artilces:

superreview requested: [Bug 426776] If a folder contains a 'broken' symbolic link, you can't navigate to it in Firefox using the file:/// URL. : [Attachment 313548] Patch rev. 1
Mats Palmgren <mats.palmgren@bredband.net> has asked Christian :Biesinger <cbiesinger@gmail.com> for superreview: Bug 426776: If a folder contains a 'broken' symbolic link, you can't navigate to it in Firefox using the file:/// URL. https://bugzilla.mozilla.org/show_bug.cgi?id=426776 Attachment 313548: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=313548&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> netwerk/base/src/nsDirectoryIndexStream.cpp: On MacOSX, IsFile() and IsDirectory() returns N...

superreview cancelled: [Bug 363573] Table cells don't expand to contain <pre cols> ('ch' unit is broken) : [Attachment 248510] Patch rev. 1
Mats Palmgren <mats.palmgren@bredband.net> has cancelled superreview: Bug 363573: Table cells don't expand to contain <pre cols> ('ch' unit is broken) https://bugzilla.mozilla.org/show_bug.cgi?id=363573 Attachment 248510: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=248510&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> Ok, I made both ComputeHorizontalValue and ComputeVerticalValue use GetAbsoluteCoord, the latter made 'ch' work for 'height', 'min-height' and 'max...

superreview requested: [Bug 363573] Table cells don't expand to contain <pre cols> ('ch' unit is broken) : [Attachment 248510] Patch rev. 1
Mats Palmgren <mats.palmgren@bredband.net> has asked David Baron <dbaron@mozilla.com> for superreview: Bug 363573: Table cells don't expand to contain <pre cols> ('ch' unit is broken) https://bugzilla.mozilla.org/show_bug.cgi?id=363573 Attachment 248510: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=248510&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> The 'cols' attribute is mapped to a 'ch' unit width. This patch implements the 'ch' unit generally for 'wid...

superreview cancelled: [Bug 78786] [FIX] Can't scroll URL bar history drop down with mouse wheel : [Attachment 153557] Patch A rev. 1 (must have patch from bug 97283 first)
Mats Palmgren <mats.palmgren@bredband.net> has cancelled Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 78786: [FIX] Can't scroll URL bar history drop down with mouse wheel http://bugzilla.mozilla.org/show_bug.cgi?id=78786 Attachment 153557: Patch A rev. 1 (must have patch from bug 97283 first) http://bugzilla.mozilla.org/attachment.cgi?id=153557&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> "Patch B rev. 2" on bug 97283 now includes a fix for this bug too. ...

superreview canceled: [Bug 424333] crafted gif file will crash firefox [XError: 'BadAlloc (insufficient resources for operation)'] : [Attachment 311249] Trunk patch, rev. 1
Mats Palmgren <mats.palmgren@bredband.net> has canceled Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 424333: crafted gif file will crash firefox [XError: 'BadAlloc (insufficient resources for operation)'] https://bugzilla.mozilla.org/show_bug.cgi?id=424333 Attachment 311249: Trunk patch, rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=311249&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> Same as rev. 1 with an addition to fix bug 427385: There are two calls to gdk_pixmap_n...

superreview granted: [Bug 363573] Table cells don't expand to contain <pre cols> ('ch' unit is broken) : [Attachment 248557] Patch rev. 2
David Baron <dbaron@mozilla.com> has granted superreview: Bug 363573: Table cells don't expand to contain <pre cols> ('ch' unit is broken) https://bugzilla.mozilla.org/show_bug.cgi?id=363573 Attachment 248557: Patch rev. 2 https://bugzilla.mozilla.org/attachment.cgi?id=248557&action=edit ------- Additional Comments from David Baron <dbaron@mozilla.com> r+sr=dbaron. Let's do the renaming in a separate patch after this one lands. (You can if you want, or I can...) ...

superreview requested: [Bug 363573] Table cells don't expand to contain <pre cols> ('ch' unit is broken) : [Attachment 248557] Patch rev. 2
Mats Palmgren <mats.palmgren@bredband.net> has asked David Baron <dbaron@mozilla.com> for superreview: Bug 363573: Table cells don't expand to contain <pre cols> ('ch' unit is broken) https://bugzilla.mozilla.org/show_bug.cgi?id=363573 Attachment 248557: Patch rev. 2 https://bugzilla.mozilla.org/attachment.cgi?id=248557&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> Ok, I made both ComputeHorizontalValue and ComputeVerticalValue use GetAbsoluteCoord, the latter made 'ch' work for 'height&#...

superreview granted: [Bug 299839] If I use the option 'reset camino' it removes downloaded files out of my download location. : [Attachment 189206] Alternative patch, don't cancel finnished downloads
Mike Pinkerton <pinkerton@aol.net> has granted Mike Pinkerton <pinkerton@aol.net>'s request for superreview: Bug 299839: If I use the option 'reset camino' it removes downloaded files out of my download location. https://bugzilla.mozilla.org/show_bug.cgi?id=299839 Attachment 189206: Alternative patch, don't cancel finnished downloads https://bugzilla.mozilla.org/attachment.cgi?id=189206&action=edit ------- Additional Comments from Mike Pinkerton <pinkerton@aol.net> sr=pink. i prefer this as well. ...

superreview requested: [Bug 363654] .url files opened via File:Open don't open/don't open properly on the 1.8.0 branch : [Attachment 248458] disables .url in file:open
Smokey Ardisson (unreliable; no bugmail) <alqahira@ardisson.org> has asked Stuart Morgan <stuart.morgan@alumni.case.edu> for superreview: Bug 363654: .url files opened via File:Open don't open/don't open properly on the 1.8.0 branch https://bugzilla.mozilla.org/show_bug.cgi?id=363654 Attachment 248458: disables .url in file:open https://bugzilla.mozilla.org/attachment.cgi?id=248458&action=edit ------- Additional Comments from Smokey Ardisson (unreliable; no bugmail) <alqahira@ardisson.org> Asking for sr on this 7-char patch in case we need to take it ...

superreview granted: [Bug 363654] .url files opened via File:Open don't open/don't open properly on the 1.8.0 branch : [Attachment 248458] disables .url in file:open
Stuart Morgan <stuart.morgan@alumni.case.edu> has granted Smokey Ardisson (unreliable; no bugmail) <alqahira@ardisson.org>'s request for superreview: Bug 363654: .url files opened via File:Open don't open/don't open properly on the 1.8.0 branch https://bugzilla.mozilla.org/show_bug.cgi?id=363654 Attachment 248458: disables .url in file:open https://bugzilla.mozilla.org/attachment.cgi?id=248458&action=edit ------- Additional Comments from Stuart Morgan <stuart.morgan@alumni.case.edu> Well, that kinda sucks. ...

superreview canceled: [Bug 93725] 'bolder' and 'lighter' keywords of 'font-weight' don't work : [Attachment 323226] possible patch for this and #77882
Zack Weinberg <zweinberg@mozilla.com> has canceled Zack Weinberg <zweinberg@mozilla.com>'s request for superreview: Bug 93725: 'bolder' and 'lighter' keywords of 'font-weight' don't work https://bugzilla.mozilla.org/show_bug.cgi?id=93725 Attachment 323226: possible patch for this and #77882 https://bugzilla.mozilla.org/attachment.cgi?id=323226&action=edit ------- Additional Comments from Zack Weinberg <zweinberg@mozilla.com> retracting review request. ...

superreview cancelled: [Bug 283016] IDN problem: using 'DIVISION SLASH'(U+2215) or 'FRACTION SLASH'(U+2044) in sub-domain : [Attachment 189179] Patch rv4.1
Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com> has cancelled Masayuki Nakano (Mozilla Japan) <masayuki@d-toybox.com>'s request for superreview: Bug 283016: IDN problem: using 'DIVISION SLASH'(U+2215) or 'FRACTION SLASH'(U+2044) in sub-domain https://bugzilla.mozilla.org/show_bug.cgi?id=283016 Attachment 189179: Patch rv4.1 https://bugzilla.mozilla.org/attachment.cgi?id=189179&action=edit ...

superreview cancelled: [Bug 261717] Can't copy Website header (URL) in RSS message's header : [Attachment 165556] patch that enables a context menu to copy the URL (now localizable)
Scott MacGregor <mscott@mozilla.org> has cancelled David Fraser <davidf@sjsoft.com>'s request for superreview: Bug 261717: Can't copy Website header (URL) in RSS message's header https://bugzilla.mozilla.org/show_bug.cgi?id=261717 Attachment 165556: patch that enables a context menu to copy the URL (now localizable) https://bugzilla.mozilla.org/attachment.cgi?id=165556&action=edit ...

superreview requested: [Bug 299192] can we rework the quotes in: Error: Unexpected end of file while searching for '';' or '}' to end declaration'. : [Attachment 187728] patch
David Baron <dbaron@mozillafoundation.org> has asked Boris Zbarsky (No email until July) <bzbarsky@mit.edu> for superreview: Bug 299192: can we rework the quotes in: Error: Unexpected end of file while searching for '';' or '}' to end declaration'. https://bugzilla.mozilla.org/show_bug.cgi?id=299192 Attachment 187728: patch https://bugzilla.mozilla.org/attachment.cgi?id=187728&action=edit ------- Additional Comments from David Baron <dbaron@mozillafoundation.org> Yeah, I don't think this was intended. ...

Web resources about - superreview canceled: [Bug 426776] If a folder contains a 'broken' symbolic link, you can't navigate to it in Firefox using the file:/// URL. : [Attachment 313548] Patch rev. 1 - mozilla.dev.super-review

Resources last updated: 11/27/2015 6:34:25 AM