superreview canceled: [Bug 382369] Cannot select text in <label> associated with a <select> : [Attachment 281681] Alternative patch, rev. 2

Robert O'Callahan (:roc) (Mozilla Corporation) <roc@ocallahan.org> has canceled
Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview:
Bug 382369: Cannot select text in <label> associated with a <select>
https://bugzilla.mozilla.org/show_bug.cgi?id=382369

Attachment 281681: Alternative patch, rev. 2
https://bugzilla.mozilla.org/attachment.cgi?id=281681&action=edit
0
bugzilla
7/21/2008 11:54:58 AM
mozilla.dev.super-review 29307 articles. 3 followers. Post Follow

0 Replies
484 Views

Similar Articles

[PageSpeed] 47

Reply:

Similar Artilces:

superreview canceled: [Bug 382369] Cannot select text in <label> associated with a <select>
Mats Palmgren <mats.palmgren@bredband.net> has canceled Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 382369: Cannot select text in <label> associated with a <select> https://bugzilla.mozilla.org/show_bug.cgi?id=3D382369 Attachment 280664: Alternative patch, rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=3D280664&action=3Dedit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> Measure the distance from the mouse-down -- assume it's a selection gesture= =0D if more than 2 pixels. I...

superreview requested: [Bug 382369] Cannot select text in <label> associated with a <select> #2
Mats Palmgren <mats.palmgren@bredband.net> has asked Robert O'Callahan (:ro= c) <roc@ocallahan.org> for superreview: Bug 382369: Cannot select text in <label> associated with a <select> https://bugzilla.mozilla.org/show_bug.cgi?id=3D382369 Attachment 281681: Alternative patch, rev. 2 https://bugzilla.mozilla.org/attachment.cgi?id=3D281681&action=3Dedit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> Measure the distance from the mouse-down -- assume it's a selection gesture= =0D if more than 2 pixels. It's ...

superreview requested: [Bug 382369] Cannot select text in <label> associated with a <select>
Mats Palmgren <mats.palmgren@bredband.net> has asked Robert O'Callahan <roc@ocallahan.org> for superreview: Bug 382369: Cannot select text in <label> associated with a <select> https://bugzilla.mozilla.org/show_bug.cgi?id=382369 Attachment 280664: Alternative patch, rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=280664&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> This patch checks for a mouse grabber during MOUSE_MOVE and sets a bit that will cause the next click to be ignored. (Let me know if t...

superreview granted: [Bug 185098] Font style ignored if <option selected="selected"> in a <select> that contains an optgroup : [Attachment 154999] Patch rev. 1
Boris Zbarsky <bzbarsky@mit.edu> has granted Boris Zbarsky <bzbarsky@mit.edu>'s request for superreview: Bug 185098: Font style ignored if <option selected="selected"> in a <select> that contains an optgroup http://bugzilla.mozilla.org/show_bug.cgi?id=185098 Attachment 154999: Patch rev. 1 http://bugzilla.mozilla.org/attachment.cgi?id=154999&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> Yeah, this is reasonable. r+sr=bzbarsky. For future reference, using more context and the -p option makes the diff...

superreview cancelled: [Bug 235872] <menupopup> does not render <labels> in current selection : [Attachment 142586] final patch, adds same to firefox
Daniel Brooks <db48x@yahoo.com> has cancelled Daniel Brooks <db48x@yahoo.com>'s request for superreview: Bug 235872: <menupopup> does not render <labels> in current selection http://bugzilla.mozilla.org/show_bug.cgi?id=235872 Attachment 142586: final patch, adds same to firefox http://bugzilla.mozilla.org/attachment.cgi?id=142586&action=edit ...

superreview requested: [Bug 305705] Whitespace in <option> of <select> isn't selectable when width is specified. : [Attachment 200452] Patch rev. 1 (diff -w)
Mats Palmgren <mats.palmgren@bredband.net> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 305705: Whitespace in <option> of <select> isn't selectable when width is specified. https://bugzilla.mozilla.org/show_bug.cgi?id=305705 Attachment 200452: Patch rev. 1 (diff -w) https://bugzilla.mozilla.org/attachment.cgi?id=200452&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> The problem is that "if (aDesiredSize.width > dropdownDesiredSize.width)" is false so we never do the second...

superreview granted: [Bug 305705] Whitespace in <option> of <select> isn't selectable when width is specified. : [Attachment 200452] Patch rev. 1 (diff -w)
Boris Zbarsky <bzbarsky@mit.edu> has granted Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 305705: Whitespace in <option> of <select> isn't selectable when width is specified. https://bugzilla.mozilla.org/show_bug.cgi?id=305705 Attachment 200452: Patch rev. 1 (diff -w) https://bugzilla.mozilla.org/attachment.cgi?id=200452&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> Looks reasonable. Watch Tp carefully, though! ...

superreview cancelled: [Bug 244179] tabindex not honoured if form element is focused via <LABEL> : [Attachment 154764] In GetDocSelectionLocation, don't return selection in a <label> because we shoul
Aaron Leventhal <aaronleventhal@moonset.net> has cancelled Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 244179: tabindex not honoured if form element is focused via <LABEL> http://bugzilla.mozilla.org/show_bug.cgi?id=244179 Attachment 154764: In GetDocSelectionLocation, don't return selection in a <label> because we should tab relative to focus when selection is inside label http://bugzilla.mozilla.org/attachment.cgi?id=154764&action=edit ...

superreview requested: [Bug 235872] <menupopup> does not render <labels> in current selection : [Attachment 142586] final patch, adds same to firefox
Daniel Brooks <db48x@yahoo.com> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 235872: <menupopup> does not render <labels> in current selection http://bugzilla.mozilla.org/show_bug.cgi?id=235872 Attachment 142586: final patch, adds same to firefox http://bugzilla.mozilla.org/attachment.cgi?id=142586&action=edit ------- Additional Comments from Daniel Brooks <db48x@yahoo.com> requesting r= and sr= ...

superreview requested: [Bug 333243] Options inside <optgroup>s in RTL <selects>s are not indented : [Attachment 217684] patch #2
Uri Bernstein <uriber@gmail.com> has asked David Baron <dbaron@mozilla.com> for superreview: Bug 333243: Options inside <optgroup>s in RTL <selects>s are not indented https://bugzilla.mozilla.org/show_bug.cgi?id=333243 Attachment 217684: patch https://bugzilla.mozilla.org/attachment.cgi?id=217684&action=edit ...

superreview granted: [Bug 303620] Focus rectangle drawn at <select> when focus is actually on <input> : [Attachment 192375] Very sensible change -- same exact thing for button, select, input and text
Brian Ryner <bryner@brianryner.com> has granted Aaron Leventhal <aaronleventhal@moonset.net>'s request for superreview: Bug 303620: Focus rectangle drawn at <select> when focus is actually on <input> https://bugzilla.mozilla.org/show_bug.cgi?id=303620 Attachment 192375: Very sensible change -- same exact thing for button, select, input and textarea. Don't assume that focus stays what you set it to after a SetContentState(NS_EVENT_STATE_FOCUS) https://bugzilla.mozilla.org/attachment.cgi?id=192375&action=edit ...

superreview cancelled: [Bug 344434] Crash [@ nsContentUtils::ComparePosition] involving <xul:toolbar> and <xul:toolbarpalette> : [Attachment 229127] Patch rev. 1 #2
Mats Palmgren <mats.palmgren@bredband.net> has cancelled superreview: Bug 344434: Crash [@ nsContentUtils::ComparePosition] involving <xul:toolbar> and <xul:toolbarpalette> https://bugzilla.mozilla.org/show_bug.cgi?id=344434 Attachment 229127: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=229127&action=edit ...

superreview granted: [Bug 300474] [FIX] <SELECT> with the MULTIPLE attribute and <OPTGROUP> item don't display properly : [Attachment 189490] Patch rev. 1
Boris Zbarsky <bzbarsky@mit.edu> has granted Mats Palmgren <mats.palmgren@bredband.net>'s request for superreview: Bug 300474: [FIX] <SELECT> with the MULTIPLE attribute and <OPTGROUP> item don't display properly https://bugzilla.mozilla.org/show_bug.cgi?id=300474 Attachment 189490: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=189490&action=edit ------- Additional Comments from Boris Zbarsky <bzbarsky@mit.edu> >Index: layout/forms/nsListControlFrame.cpp >+ nsIPresShell* shell = aPresContext->GetPresShell(); I thi...

superreview requested: [Bug 300474] [FIX] <SELECT> with the MULTIPLE attribute and <OPTGROUP> item don't display properly : [Attachment 189490] Patch rev. 1
Mats Palmgren <mats.palmgren@bredband.net> has asked Boris Zbarsky <bzbarsky@mit.edu> for superreview: Bug 300474: [FIX] <SELECT> with the MULTIPLE attribute and <OPTGROUP> item don't display properly https://bugzilla.mozilla.org/show_bug.cgi?id=300474 Attachment 189490: Patch rev. 1 https://bugzilla.mozilla.org/attachment.cgi?id=189490&action=edit ------- Additional Comments from Mats Palmgren <mats.palmgren@bredband.net> These two changes are not needed to fix this bug: Removed an unused parameter from GetMaxOptionHeight(). Make sure GetNum...

Web resources about - superreview canceled: [Bug 382369] Cannot select text in <label> associated with a <select> : [Attachment 281681] Alternative patch, rev. 2 - mozilla.dev.super-review

Resources last updated: 1/8/2016 7:49:28 AM